hermes-bot
679d1408e6
review-bot 1802 on #1417 (blocking): marker dedupe was per card, but the PR's Hermes-Card line moves (follow-up card, coordinator hand-off, gitea_pr.py adopt), so a replay re-sent findings already handled on the earlier card to the new one. A finding older than the card the line names now is skipped (review submitted_at / comment created_at vs the card's created_at); the new card's worker reads the PR itself. Also from the review: - PR merged or closed while its card is in review completes the card (hook event pull_request_only, route event pull_request, closed hermes-bot PRs of the replay window are replayed); a rebuttal without push otherwise left the card in review forever once the owner merged. - 404 on the PR (system hook fires for repos hermes-bot cannot read) is a skip, not an error line per review. - One route-script run per PR at a time (flock): a delivery and its replay can overlap. - find_review drops dismissed reviews like the replay does. - Replay checks the run budget before listing; CronJob comment updated. - Skill: stun-tls-probe.py runs via python3 (ConfigMap mode 0644); rebuttal wording says the card waits for the owner.
homelab
GitOps source for the Renner homelab cluster. Flux applies main to
production, so every merge is a production change. Changes go in by pull
request only; see CONTRIBUTING.md for YAML conventions.
Change rules that protect Home Assistant
Owner decision (REN-240, REN-243). Home Assistant runs the house, so it gets two rules on top of normal review.
1. Disruptive work runs only 02:00–05:00 Europe/Berlin
Planned work that can restart Home Assistant or disrupt the cluster is merged and applied only between 02:00 and 05:00 Europe/Berlin. That covers:
- node drain, node reboot, Talos upgrade
- CNI (Cilium, Multus) and cluster-wide network policy
- storage (Rook/Ceph, CSI, snapshot controller, CNPG operator)
- Flux core (
kubernetes/clusters/*/flux-system/, Flux controllers) - Authentik
- OpenBao, including secret rotation that restarts consumers
- anything in
kubernetes/apps/home-assistant/
A PR in this list states in its description that it waits for the window. Flux applies on merge, so "wait for the window" means merge in the window, not just apply. If unsure whether a change is disruptive, treat it as disruptive.
Not covered: Home Assistant image bumps by Flux image automation. They stay fully automatic by owner decision. If one breaks Home Assistant, roll it back with RUNBOOK-home-assistant-image-rollback.md. An incident rollback is not planned work; the owner decides its timing.
Also not covered, by owner decision: the Hermes ha-updates job
(kubernetes/apps/hermes/skills/ha-updates/) installs HACS and device-firmware
updates that Home Assistant offers, and restarts Home Assistant for them, on
its own inside the 02:00–05:00 window (UniFi and SMLIGHT firmware excluded;
reported only). The window is enforced by its ha.py, not only by the prompt.
2. HA-impact review before merge
Every PR that touches kubernetes/apps/home-assistant/, or makes a
cluster-wide disruptive change from the list above, needs an HA-impact
review before merge: a named reviewer states in the PR what Home
Assistant will notice (restart, lost integration, lost history, none) and
approves.
- Reviewer: Hestia, the Home Assistant maintainer.
- Until the owner hands this review to Hestia (the
hestiaHermes profile, which today only states the expected impact in its PRs): the owner does the HA-impact review.
This is in addition to the normal review and merge by Argus. Argus does not merge such a PR without the HA-impact approval.