chore(wiki): build.1790250017; proposal without the fact-sink port #943
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: konairius/homelab#943
Reference in New Issue
Block a user
Pins the image from Wiki PR #3 (one Gitea adapter;
INoteStoregets create, depositing a fact is a use case). The proposal's port table and layout say the same now;IFactSinkis gone.🤖 Generated with Claude Code
🤖 Automated review — model
claude-haiku-4-5-20251001(complexity: trivial), commitfc32e9943810b4390f18dfb65c02422395cd79d7.Summary
This PR updates the Wiki architecture proposal and deployment manifest to reflect consolidation of the
IFactSinkport intoINoteStore(combining read and create operations). The image is bumped frombuild.1790245544tobuild.1790250017, following the project's dated-tag convention. Changes are internally consistent and align with the architectural decision described in the PR body.🔴 Blocking
None — no correctness, security, or design issues found.
🟡 Suggestions
Image availability assumption (kubernetes/apps/wiki/deployment.yaml:51): The PR pins a new image tag (
build.1790250017) that depends on the Wiki repository's release pipeline having built and published it. This should already be in place from the referenced Wiki PR #3, but it's worth verifying the image exists ingitea.renner.uno/konairius/wikibefore merge if this is a blocking concern for deployment. The proposal states this tag comes from commit6ff8d4b; confirming that commit exists in k.renner/wiki would give confidence.Port consolidation scope (kubernetes/PROPOSAL-wiki-web-api.md:75): The proposal now states
INoteStorehandles both "read notes... at a head; create a new document" but the description "a fact becomes a raw note in the application layer, the store only moves text" should be verified against the Application layer implementation. If the boundary between domain type conversion and storage has shifted, ensure tests validate the contract (the proposal mentions contract test suites intest/Wiki.Contracts).🟢 Nits
c4e193bto6ff8d4b— this is correct and mirrors the image tag bump, but it's incidental to the real change (the tag itself is the version; the commit is just for documentation).Tests
The changes are primarily documentation and configuration:
kubernetes/PROPOSAL-wiki-web-api.md): documentation-only, no tests required beyond human review that the removal ofIFactSinkand consolidation intoINoteStoreis intentional and consistent.kubernetes/apps/wiki/deployment.yaml): YAML is syntactically valid. The kustomize build will pass (deployment.yaml is referenced in kustomization.yaml and contains valid Kubernetes resource definitions). The actual behavior change (running the new image) will only be validated when the pod starts and its probes succeed, which is a runtime concern beyond this PR.The PR assumes the contract tests in the Wiki repository (
test/Wiki.Contracts) already validated that the newINoteStoreimplementation (with create support) works against the Gitea adapter.Recommendation
Looks reasonable — no blocking issues; verify the
build.1790250017image exists in the registry before merge if image availability is a merge criterion.