konairius/homelab
10
0
Fork 0
Code Issues 8 Pull Requests 4 Packages Projects Releases 1 Wiki Activity

chore(monitoring-rules): remove temporary REN-28 negative-test probes (REN-159) #1052

Merged
Ghost merged 1 commits from atlas/ren-159-remove-ren28-negative-probes into master 2026-09-28 00:13:08 +00:00
Conversation 2 Commits 1 Files Changed 3
+2 -110
Ghost commented 2026-09-28 00:12:07 +00:00
Copy Link
Copy Source

What changed

Removes the temporary blackbox-ren28-negative Probe (added in #1015 for the REN-140 §7 before/after pair):

  • delete kubernetes/apps/monitoring-rules/probes-ren28-negative.yaml
  • delete its kustomization.yaml entry and the 3-line # TEMPORARY, REN-140 comment
  • drop the now-dangling mention of blackbox-ren28-negative from the comment above CNPNegativeControlReachable in prometheusrule-blackbox.yaml (comment only; expr, for, labels unchanged)

Why

The Probe was temporary by design. Its "after" half was read at #1044's merge (27b505e6, 2026-09-28 00:09–00:11Z, Argus on REN-272): all four targets probe_success 0 at probe_duration_seconds 5.000–5.001 s (policy drop, not a dead endpoint), :9187 pod IPs unmoved, collateral paperless login probe and up{job="paperless/cnpg-pprl-pg"} still 1. Leaving it would keep four permanently-red series with no alert and no owner.

gotenberg:3000 stays watched by the permanent blackbox-negative-control job + CNPNegativeControlReachable. The :9187 and pprl-pg-r:5432 targets have no successor by design (accepted residual, recorded on REN-159).

How verified

  • git grep -i ren28 on the branch: no hits left.
  • Every entry in monitoring-rules/kustomization.yaml resolves to an existing file.
  • No PrometheusRule/alert matches job="blackbox-ren28-negative", so nothing is orphaned. Static only; not yet reconciled.

Revert

git revert this commit; Flux recreates the Probe. No workload, restart, secret or policy touched.

🤖 Generated with Claude Code

## What changed Removes the temporary `blackbox-ren28-negative` Probe (added in #1015 for the REN-140 §7 before/after pair): - delete `kubernetes/apps/monitoring-rules/probes-ren28-negative.yaml` - delete its `kustomization.yaml` entry and the 3-line `# TEMPORARY, REN-140` comment - drop the now-dangling mention of `blackbox-ren28-negative` from the comment above `CNPNegativeControlReachable` in `prometheusrule-blackbox.yaml` (comment only; `expr`, `for`, labels unchanged) ## Why The Probe was temporary by design. Its "after" half was read at #1044's merge (`27b505e6`, 2026-09-28 00:09–00:11Z, Argus on REN-272): all four targets `probe_success` 0 at `probe_duration_seconds` 5.000–5.001 s (policy drop, not a dead endpoint), `:9187` pod IPs unmoved, collateral paperless login probe and `up{job="paperless/cnpg-pprl-pg"}` still 1. Leaving it would keep four permanently-red series with no alert and no owner. `gotenberg:3000` stays watched by the permanent `blackbox-negative-control` job + `CNPNegativeControlReachable`. The `:9187` and `pprl-pg-r:5432` targets have no successor by design (accepted residual, recorded on REN-159). ## How verified - `git grep -i ren28` on the branch: no hits left. - Every entry in `monitoring-rules/kustomization.yaml` resolves to an existing file. - No PrometheusRule/alert matches `job="blackbox-ren28-negative"`, so nothing is orphaned. Static only; not yet reconciled. ## Revert `git revert` this commit; Flux recreates the Probe. No workload, restart, secret or policy touched. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Ghost added 1 commit 2026-09-28 00:12:08 +00:00
chore(monitoring-rules): remove temporary REN-28 negative-test probes (REN-159)
ci/woodpecker/pr/ci-scripts-test Pipeline was successful
Details
ci/woodpecker/pr/ci-manifests-test Pipeline was successful
Details
ci/woodpecker/pr/pr-review Pipeline was successful
Details
725d4a5204 
The blackbox-ren28-negative Probe existed only to take the REN-140 §7
before/after pair across REN-28 PR 2b (#1044). The "after" reading was
taken at merge (27b505e6, 2026-09-28 00:09-00:11Z): all four targets
probe_success 0 at probe_duration_seconds ~5 s, collateral still 1.

Delete the Probe, its kustomization entry, and the now-dangling mention
of the job in the CNPNegativeControlReachable comment. gotenberg:3000
stays covered by the permanent blackbox-negative-control job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ghost approved these changes 2026-09-28 00:13:08 +00:00
Ghost left a comment
Copy Link
Copy Source

Approved at 725d4a5204: git grep -i ren28 empty; all 37 kustomization resources resolve; rule diff comment-only; Flux prune: true on monitoring-rules.

Approved at 725d4a5204e8b85422d2138d1f7479789eebf5d4: git grep -i ren28 empty; all 37 kustomization resources resolve; rule diff comment-only; Flux prune: true on monitoring-rules.
Ghost merged commit b69c7f8985 into master 2026-09-28 00:13:08 +00:00
review-bot left a comment
Member
Copy Link
Copy Source

🤖 Automated review — model CLI default (complexity: unknown), commit 725d4a5204e8b85422d2138d1f7479789eebf5d4.

Advisory review by the review-bot pipeline. It never approves; a human merges. Push new commits to get a fresh review.

Summary

Pure deletion PR: removes the temporary blackbox-ren28-negative Probe (probes-ren28-negative.yaml), its kustomization.yaml entry, and a now-dangling comment mention in prometheusrule-blackbox.yaml. No expr, for, or labels are touched on any live rule. I independently confirmed the PR's own verification claims — no blocking issues.

Tests

Not applicable in the unit-test sense (GitOps YAML/Kustomize, no CI test suite covers this path). I verified the equivalent static checks myself:

  • grep -ri 'ren28-negative' across the whole repo: no hits — nothing else references the deleted job name or file (kubernetes/apps/monitoring-rules/kustomization.yaml, prometheusrule-blackbox.yaml checked directly).
  • Every resource listed in kubernetes/apps/monitoring-rules/kustomization.yaml resolves to a file that exists on disk.
  • prometheusrule-blackbox.yaml's CNPNegativeControlReachable alert (expr: probe_success{job="blackbox-negative-control"} == 1, for: 15m, labels.severity: warning) is byte-identical before/after; only the preceding comment lost its blackbox-ren28-negative clause.
  • kubernetes/clusters/homelab/monitoring.yaml shows the monitoring-rules Flux Kustomization has prune: true, so the live Probe object will actually be deleted on reconcile, not orphaned — consistent with the PR's revert note ("Flux recreates the Probe").

Recommendation

Looks reasonable — no blocking issues; comments above are optional (there are none).

🤖 **Automated review** — model `CLI default` (complexity: unknown), commit `725d4a5204e8b85422d2138d1f7479789eebf5d4`. > Advisory review by the `review-bot` pipeline. It never approves; a human merges. Push new commits to get a fresh review. --- ## Summary Pure deletion PR: removes the temporary `blackbox-ren28-negative` Probe (`probes-ren28-negative.yaml`), its `kustomization.yaml` entry, and a now-dangling comment mention in `prometheusrule-blackbox.yaml`. No `expr`, `for`, or `labels` are touched on any live rule. I independently confirmed the PR's own verification claims — no blocking issues. ## Tests Not applicable in the unit-test sense (GitOps YAML/Kustomize, no CI test suite covers this path). I verified the equivalent static checks myself: - `grep -ri 'ren28-negative'` across the whole repo: no hits — nothing else references the deleted job name or file (`kubernetes/apps/monitoring-rules/kustomization.yaml`, `prometheusrule-blackbox.yaml` checked directly). - Every resource listed in `kubernetes/apps/monitoring-rules/kustomization.yaml` resolves to a file that exists on disk. - `prometheusrule-blackbox.yaml`'s `CNPNegativeControlReachable` alert (`expr: probe_success{job="blackbox-negative-control"} == 1`, `for: 15m`, `labels.severity: warning`) is byte-identical before/after; only the preceding comment lost its `blackbox-ren28-negative` clause. - `kubernetes/clusters/homelab/monitoring.yaml` shows the `monitoring-rules` Flux Kustomization has `prune: true`, so the live `Probe` object will actually be deleted on reconcile, not orphaned — consistent with the PR's revert note ("Flux recreates the Probe"). ## Recommendation Looks reasonable — no blocking issues; comments above are optional (there are none). <!-- pr-review:sha=725d4a5204e8b85422d2138d1f7479789eebf5d4 -->
Sign in to join this conversation.
Reviewers
No Reviewers
Ghost
review-bot
Labels
Clear labels
apollo
Hermes expert: Immich, Audiobookshelf, Libation, Navidrome, Music Assistant
 atlas
Hermes expert: Talos, Flux, network, Authentik, Matrix, monitoring
 clio
Hermes expert: Paperless, wiki, ical-proxy, TRMNL, websites
 daedalus
Hermes expert: Gitea, Woodpecker, Renovate, review-bot, Hermes
 hestia
Hermes expert: Home Assistant, IoT, MQTT, ESPHome, voice
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
alert-monitor-bot claude-bot (Claude Bot) flux hermes-bot issue-fix-bot k.renner renovate-bot review-bot (Review Bot) security-bot update-audit-bot
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: konairius/homelab#1052