fix(ci): pr-review.yml parse error — literal ${...} in a comment broke the live pipeline #367
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: konairius/homelab#367
Reference in New Issue
Block a user
Hotfix — the homelab pr-review pipeline has been erroring on every PR event since #362 merged.
Woodpecker runs its
${...}variable substitution over the entire pipeline YAML, comments included. A comment added in #362 (documenting why the manual trigger was dropped) contained a literal${...}, which Woodpecker tried to parse as a variable →unable to parse variable name→ the pipeline errors before any workflow starts. Observed on pipeline #2089 (pull_request on #363): statuserror, zero workflows.Fix: reword the comment to avoid the dollar-brace glyph, and add a note warning against reintroducing it. One-line comment change, no behavior change.
The same line exists in the three sibling PRs (shelly #49, authentik #3, HA #180); fixing those on their branches too.
Woodpecker runs its ${...} variable substitution over the ENTIRE pipeline YAML including comments, so the literal dollar-brace in the triggering comment (added when documenting the dropped manual path) failed to parse — 'unable to parse variable name' — erroring every pull_request pipeline before any step ran. Reword the comment to avoid the glyph; the live homelab pipeline was down since #362 merged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>🤖 Automated review — model
claude-haiku-4-5-20251001(complexity: trivial), commit2573547753f4fc0cd2a815457a45ba06f9093eef.Summary
This PR fixes a production pipeline failure introduced by a comment in PR #362 containing a literal
${...}string. Woodpecker runs variable substitution over the entire YAML (including comments), and the unparseable variable reference caused all PR review pipelines to error before any step could run. The fix removes the literal${...}, rewords the comment for clarity, and adds a warning note to prevent reintroduction of the issue.🔴 Blocking
None. This is a straightforward comment-only fix with no risk.
🟢 Nits
Grammar improvement (optional):
.woodpecker/pr-review.yml:52-57— The rephrasing is clearer overall. "Woodpecker exposes a --var only to YAML variable substitution" reads more naturally than the original. Minor note: the original said "filters only" (implying exactly two locations), while the new version says "NOT to a step's shell environment" (explicitly negating the most likely misuse). This is actually more precise and helpful.Tests
No tests are needed or applicable — this is a CI configuration fix to resolve a pipeline syntax error. The fix can only be verified by running the Woodpecker pipeline on a pull request, which the PR body confirms has been observed as failing (pipeline #2089). Once merged, subsequent PR events will confirm the fix works.
Recommendation
Looks reasonable — no blocking issues. This is a minimal, focused hotfix for a real production issue that has broken the review pipeline on all PRs since #362 merged.