revert(music-assistant): remove PO token server #1456

2026-10-26T10:11:20Z

claude-bot commented

2026-10-26 10:11:20 +00:00

Reverts #1451. The YouTube Music provider is not kept, so the PO token server goes:

deletes kubernetes/apps/music-assistant/po-token-server.yaml (Deployment, Service, CNP)
deletes the bgutil-pot-provider ImageRepository/ImagePolicy and its README row

Both owning Kustomizations (music-assistant, infrastructure) have prune: true, so Flux removes the live objects on merge. No other references remain (grep -rn 'po-token\|bgutil' kubernetes/ is empty); both kustomizations render.

The YouTube Music provider itself lives in MA's settings.json and is removed in the MA UI.

🤖 Generated with Claude Code

Reverts #1451. The YouTube Music provider is not kept, so the PO token server goes: - deletes `kubernetes/apps/music-assistant/po-token-server.yaml` (Deployment, Service, CNP) - deletes the `bgutil-pot-provider` ImageRepository/ImagePolicy and its README row Both owning Kustomizations (`music-assistant`, `infrastructure`) have `prune: true`, so Flux removes the live objects on merge. No other references remain (`grep -rn 'po-token\|bgutil' kubernetes/` is empty); both kustomizations render. The YouTube Music provider itself lives in MA's settings.json and is removed in the MA UI. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-26 10:11:20 +00:00

revert(music-assistant): remove PO token server

ci/woodpecker/pr/ci-manifests-test Pipeline was successful

Details

ci/woodpecker/pr/ci-scripts-test Pipeline was successful

Details

0f86537bb1

Reverts #1451. The YouTube Music provider is not kept; the PO token
server and its image automation go with it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

review-bot approved these changes

2026-10-26 10:12:12 +00:00

review-bot left a comment

🤖 Automated review — model claude-sonnet-5-5, commit 0f86537bb133a9d51b5fbc32eabe183aa560ac9c.

Automated review by the review-bot: it approves only when it found nothing red or yellow, and a human still merges. Push new commits to get a fresh review.

Summary

This PR reverts the commit that added the PO token server (96ea510). It deletes po-token-server.yaml (Deployment, Service, CNP) and the bgutil-pot-provider ImageRepository/ImagePolicy. It also removes their entries from both kustomizations and the README row. The diff is the exact inverse of 96ea510: the same five files change and the content matches line for line. I found nothing wrong with it.

Checks:

The PR is mergeable and based on main at 31459da. Nothing on the base touches these files after 96ea510, so there is no conflict and no overlap with another change.
The remaining kubernetes/apps/music-assistant/kustomization.yaml and kubernetes/infrastructure/image-automation/kustomization.yaml at the head sha no longer list the deleted files.
deployment.yaml for music-assistant has no reference to po-token-server, port 4416 or bgutil. No other CNP or env var depends on the removed Service.
The PR has no earlier reviews or comments, so this is a first review.

⚪ Unverified

The PR says a repo-wide grep -rn 'po-token\|bgutil' kubernetes/ is empty. I could not run grep with the tools I have. I read the music-assistant directory and both kustomizations, and an issue and PR search for "po-token" only returned this PR. I did not read every file in the repo.
prune: true on the owning Kustomizations is taken from the PR body. I did not open the Flux Kustomization manifests. If prune were off, the live Deployment, Service, CNP, ImageRepository and ImagePolicy would stay behind as orphans.

Tests

No tests apply. This is a manifest-only removal, and the PR says both kustomizations still render.

Recommendation

Looks reasonable — no blocking issues.

🤖 **Automated review** — model `claude-sonnet-5-5`, commit `0f86537bb133a9d51b5fbc32eabe183aa560ac9c`. > Automated review by the `review-bot`: it approves only when it found nothing red or yellow, and a human still merges. Push new commits to get a fresh review. --- ## Summary This PR reverts the commit that added the PO token server (96ea510). It deletes `po-token-server.yaml` (Deployment, Service, CNP) and the `bgutil-pot-provider` ImageRepository/ImagePolicy. It also removes their entries from both kustomizations and the README row. The diff is the exact inverse of 96ea510: the same five files change and the content matches line for line. I found nothing wrong with it. Checks: - The PR is mergeable and based on `main` at 31459da. Nothing on the base touches these files after 96ea510, so there is no conflict and no overlap with another change. - The remaining `kubernetes/apps/music-assistant/kustomization.yaml` and `kubernetes/infrastructure/image-automation/kustomization.yaml` at the head sha no longer list the deleted files. - `deployment.yaml` for music-assistant has no reference to `po-token-server`, port 4416 or bgutil. No other CNP or env var depends on the removed Service. - The PR has no earlier reviews or comments, so this is a first review. ## ⚪ Unverified - The PR says a repo-wide `grep -rn 'po-token\|bgutil' kubernetes/` is empty. I could not run grep with the tools I have. I read the music-assistant directory and both kustomizations, and an issue and PR search for "po-token" only returned this PR. I did not read every file in the repo. - `prune: true` on the owning Kustomizations is taken from the PR body. I did not open the Flux Kustomization manifests. If prune were off, the live Deployment, Service, CNP, ImageRepository and ImagePolicy would stay behind as orphans. ## Tests No tests apply. This is a manifest-only removal, and the PR says both kustomizations still render. ## Recommendation Looks reasonable — no blocking issues.

k.renner merged commit c380c7c2b8 into main

2026-10-26 10:18:28 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: konairius/homelab#1456