From 52899ecb64f8c78f00b47682b899dfda196a19eb Mon Sep 17 00:00:00 2001
From: Claude Bot <claude-bot@renner.uno>
Date: Wed, 26 Aug 2026 10:17:36 +0200
Subject: [PATCH] fix(ci): remove update-all, which invoked a deleted playbook
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

.woodpecker/update-all.yml ran `ansible-playbook -i inventory/ plays/update.yml`
on a cron. This branch deletes that playbook, because every playbook it
imported targeted Proxmox hosts or guests that no longer exist, so the next
scheduled run would have failed outright.

Removing the pipeline rather than repointing it: there is nothing left for it
to update. Its imports were update-vm, update-lxc, update-authentik,
install-n8n, install-grist, install-music-assistant, update-docker and
update-pve-rolling — all removed here, all targeting hosts that no longer
resolve.

Swept every pipeline for references to deleted plays. The five still named
(install-claude-workstation, install-garage-synology, install-netbird-client,
install-netbird-proxy, install-netbird-server) all survive.

Also from the review:

  common.yml           `all:!pbs` was a no-op I introduced when simplifying the
                       old exclusion list — no pbs group exists. Now plain
                       `all`.
  qemu-guest-agent     dropped the `pve_cluster`/`proxmox_nodes`/
                       `proxmox_all_lxc` group guards; those groups are gone,
                       so the conditions were always true.

Caught by the review-bot on #625.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .woodpecker/update-all.yml                    | 32 -------------------
 ansible/plays/common.yml                      |  2 +-
 ansible/roles/qemu-guest-agent/tasks/main.yml |  7 ----
 3 files changed, 1 insertion(+), 40 deletions(-)
 delete mode 100644 .woodpecker/update-all.yml

diff --git a/.woodpecker/update-all.yml b/.woodpecker/update-all.yml
deleted file mode 100644
index f86250fb..00000000
--- a/.woodpecker/update-all.yml
+++ /dev/null
@@ -1,32 +0,0 @@
-when:
-  - event: cron
-    evaluate: 'PIPELINE == "update-all"'
-  - event: manual
-    evaluate: 'PIPELINE == "update-all"'
-
-timeout: 120
-
-steps:
-  - name: update-all
-    image: gitea.renner.uno/gitea_admin/ci-ansible:2026-04-29
-    environment:
-      ANSIBLE_FORCE_COLOR: "true"
-      ANSIBLE_HOST_KEY_CHECKING: "false"
-      ANSIBLE_ROLES_PATH: "../roles:./roles"
-      SSH_PRIVATE_KEY:
-        from_secret: ssh_private_key
-      VAULT_PASS:
-        from_secret: vault_pass
-      PROXMOX_TOKEN_ID:
-        from_secret: proxmox_token_id
-      PROXMOX_TOKEN_SECRET:
-        from_secret: proxmox_token_secret
-    commands:
-      - mkdir -p ~/.ssh
-      - echo "$SSH_PRIVATE_KEY" | base64 -d > ~/.ssh/id_ed25519
-      - chmod 600 ~/.ssh/id_ed25519
-      - printf "Host *\n\tStrictHostKeyChecking no\n\tUserKnownHostsFile /dev/null\n" > ~/.ssh/config
-      - cd ansible
-      - echo "$VAULT_PASS" > .vault_pass && chmod 600 .vault_pass
-      - export ANSIBLE_VAULT_PASSWORD_FILE=.vault_pass
-      - ansible-playbook -i inventory/ plays/update.yml -v
diff --git a/ansible/plays/common.yml b/ansible/plays/common.yml
index b564df82..3388a7a0 100644
--- a/ansible/plays/common.yml
+++ b/ansible/plays/common.yml
@@ -6,7 +6,7 @@
     - certificates
 
 - name: Base System Hardening & Common Configuration
-  hosts: all:!pbs
+  hosts: all
   become: true
   ignore_unreachable: true
   gather_facts: true
diff --git a/ansible/roles/qemu-guest-agent/tasks/main.yml b/ansible/roles/qemu-guest-agent/tasks/main.yml
index 5392b99a..de909190 100644
--- a/ansible/roles/qemu-guest-agent/tasks/main.yml
+++ b/ansible/roles/qemu-guest-agent/tasks/main.yml
@@ -8,9 +8,6 @@
     state: present
   when: 
     - ansible_os_family is defined and ansible_os_family == 'Debian'
-    - "'proxmox_all_lxc' not in group_names"
-    - "'proxmox_nodes' not in group_names"
-    - "'pve_cluster' not in group_names"
 
 - name: Install QEMU Guest Agent (RHEL/Rocky VMs)
   dnf:
@@ -18,13 +15,9 @@
     state: present
   when: 
     - ansible_os_family is defined and ansible_os_family == 'RedHat'
-    - "'proxmox_all_lxc' not in group_names"
-    - "'proxmox_nodes' not in group_names"
-    - "'pve_cluster' not in group_names"
 
 - name: Ensure qemu-guest-agent is started and enabled
   service:
     name: qemu-guest-agent
     state: started
     enabled: yes
-  when: "'proxmox_all_lxc' not in group_names"