docs(trmnl): cite the source for API_ACCESS_TOKEN_PERIOD
The setting was treated as an unverified assumption in review, and I repeated that framing. It was not one. Upstream's doc/configuration.adoc documents the variable and its 1800-second default in as many words, and this instance corroborated it empirically: a token minted here was rejected roughly thirty minutes later, which is the documented default behaving exactly as written. Documentation plus matching observed behaviour is not an assumption. The reviewer's uncertainty was reasonable — Terminus's source is not vendored in this repo, so from the checkout alone the claim is unsupported. The failing was mine for citing nothing at the point of use, which is the same gap as the /health probe earlier: the evidence existed and was not written where a reader could find it. Quotes the documentation inline so the question is answerable from the manifest. Note this does not make the post-merge check redundant. Whether Terminus honours the variable is settled here; whether this ConfigMap edit actually reached the running process via Reloader is a separate question, and that is what decoding the new token's exp claim answers. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -20,6 +20,13 @@ data:
|
||||
RACK_ATTACK_ALLOWED_SUBNETS: "10.0.0.0/8,172.16.0.0/12,192.168.0.0/16,127.0.0.1,::1,fc00::/7"
|
||||
# 10 years, against a default of 1800s (30 minutes).
|
||||
#
|
||||
# Documented upstream in doc/configuration.adoc:
|
||||
# API_ACCESS_TOKEN_PERIOD — "The amount of time, in seconds, the JWT
|
||||
# access token remains valid before needing to refresh your access
|
||||
# token." Default: 1,800 seconds (30 minutes).
|
||||
# Corroborated on this instance: a token minted here was rejected about
|
||||
# thirty minutes later, i.e. the documented default behaving as written.
|
||||
#
|
||||
# This exists for the renderer, which pushes screens to /api/screens with
|
||||
# a JWT held in OpenBao. At the default period that arrangement cannot
|
||||
# work unattended, and it fails in a way that has no recovery: minting a
|
||||
|
||||
Reference in New Issue
Block a user